-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streamingest: add job level test for stream ingestion #59588
Conversation
) | ||
|
||
// Dummy import to pull in kvtenantccl. This allows us to start tenants. | ||
var _ = kvtenantccl.Connector{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do this with an import line that looks like:
_ "github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvtenantccl"
665b56d
to
a06e6cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @pbardea)
pkg/ccl/streamingccl/streamingest/stream_ingestion_test.go, line 45 at r4 (raw file):
Previously, pbardea (Paul Bardea) wrote…
I think we can do this with an import line that looks like:
_ "github.com/cockroachdb/cockroach/pkg/ccl/kvccl/kvtenantccl"
Done.
pkg/sql/parser/parse_test.go, line 1724 at r4 (raw file):
Previously, pbardea (Paul Bardea) wrote…
Let's also add some tests for
RESTORE TABLE foo FROM ...
since it's supported by the grammar. Although we error on it later, I think it's worth noting in these tests that it's a grammar that we support. A comment along with the tests explaining that we'll error out later would be good too.
Done.
Going to wait for your timer change to merge before I check this in, but this should be RFAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after rebase.
@@ -0,0 +1,65 @@ | |||
// Copyright 2018 The Cockroach Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Year needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
82b5968
to
2d0f616
Compare
This change adds a test that exercises all the components of the stream ingestion flow. It fixes some missing pieces that were discovered while writing the test. Release note: None
2d0f616
to
aa6c8b5
Compare
TFTR! bors r=pbardea |
Build succeeded: |
This change adds a test that exercises all the components of the stream
ingestion flow. It fixes some missing pieces that were discovered while
writing the test.
Informs: #59175
Release note: None